Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DatadogMonitor] Do not log error if DD_MONITOR_FORCE_SYNC_PERIOD is not set #1466

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

tbavelier
Copy link
Member

What does this PR do?

Motivation

  • Avoids spamming error logs when variable is not set (default)

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@tbavelier tbavelier added the bug Something isn't working label Oct 16, 2024
@tbavelier tbavelier added this to the v1.10.0 milestone Oct 16, 2024
@tbavelier tbavelier requested a review from a team as a code owner October 16, 2024 14:33
@tbavelier tbavelier changed the title Do not log error if sync variable is not set [DatadogMonitor] Do not log error if DD_MONITOR_FORCE_SYNC_PERIOD is not set Oct 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 48.94%. Comparing base (24f18f9) to head (dfd2e59).

Files with missing lines Patch % Lines
internal/controller/datadogmonitor/controller.go 11.11% 7 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1466      +/-   ##
==========================================
- Coverage   48.95%   48.94%   -0.02%     
==========================================
  Files         223      223              
  Lines       19757    19758       +1     
==========================================
- Hits         9673     9670       -3     
- Misses       9574     9578       +4     
  Partials      510      510              
Flag Coverage Δ
unittests 48.94% <11.11%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/controller/datadogmonitor/controller.go 46.69% <11.11%> (-1.36%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f18f9...dfd2e59. Read the comment docs.

@tbavelier
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 16, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 15m.

Use /merge -c to cancel this operation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants